[ovs-dev] [PATCH v3] ovn-northd, tests: Adding IPAM to ovn-northd.

Guru Shetty guru at ovn.org
Thu Jun 30 00:15:52 UTC 2016


On 29 June 2016 at 13:53, Nimay Desai <nimaydesai1 at gmail.com> wrote:

> Added an IPv4 and MAC addresses management system to ovn-northd. When a
> logical
> switch's options:subnet field is set, logical ports attached to that switch
> that do not have a MAC/IPv4 address will automatically be allocated a
> globally
> unique MAC address/unused IPv4 address within the provided subnet. This
> can be useful for a user who wants to deploy many VM's or containers with
> networking capabilities, but does not care about the specific MAC/IPv4
> addresses that are assigned.
>
> Added tests in ovn.at for ipam.
>
> Signed-off-by: Nimay Desai <nimaydesai1 at gmail.com>
>

Thanks! This mostly looks good to me. Let us wait for a couple of days to
see if anyone else has any comments. If not, I will apply it. (We will need
to eventually support ipv6 addressing, but let us wait till Justin gets his
patches in for ipv6 support in routers for that)

It looked like this commit introduced a new page break at an odd place. It
will also need the following incremental.

diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index 4a5e7c2..a11bf22 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -782,7 +782,7 @@ ipam_get_unused_ip(struct ovn_datapath *od, uint32_t
subnet,

 static void
 ipam_allocate_addresses(struct ovn_datapath *od, struct ovn_port *op,
-                   ovs_be32 subnet, ovs_be32 mask)
+                        ovs_be32 subnet, ovs_be32 mask)
 {
     if (!od || !op || !op->nbs) {
         return;

The committer should be able to take care of it. So you don't need to send
another version till we hear other comments.



More information about the dev mailing list