[ovs-dev] [PATCH v2 08/24] datapath: backport: ip_tunnel: add support for setting flow label via collect metadata

Jesse Gross jesse at kernel.org
Thu Jun 30 20:36:43 UTC 2016


On Thu, Jun 30, 2016 at 1:06 AM, Pravin B Shelar <pshelar at ovn.org> wrote:
> diff --git a/acinclude.m4 b/acinclude.m4
> index 05b5f48..f833812 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -432,8 +432,11 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [
>    OVS_GREP_IFELSE([$KSRC/include/net/inetpeer.h], [vif],
>                    [OVS_DEFINE([HAVE_INETPEER_VIF_SUPPORT])])
>
> -  OVS_GREP_IFELSE([$KSRC/include/net/ip_tunnels.h], [iptunnel_pull_offloads],
> -                  [OVS_DEFINE([HAVE_METADATA_DST])])
> +  OVS_FIND_FIELD_IFELSE([$KSRC/include/net/ip_tunnels.h], [ip_tunnel_key],
> +                        [label],
> +                        [OVS_GREP_IFELSE([$KSRC/include/net/ip_tunnels.h],
> +                                         [iptunnel_pull_offloads],
> +                                         [OVS_DEFINE([HAVE_METADATA_DST])])])

I think it might be time to rename HAVE_METADATA_DST to something like
USE_TUNNEL_BACKPORTS since it doesn't have too much to do with tunnel
metadata anymore.

But otherwise this looks good:
Acked-by: Jesse Gross <jesse at kernel.org>



More information about the dev mailing list