[ovs-dev] [PATCH_v5 06/26] Move BLDASSERT macros to compiler header file
Ben Warren
ben at skyportsystems.com
Fri Apr 1 02:37:38 UTC 2016
> On Mar 30, 2016, at 4:27 PM, Ben Pfaff <blp at ovn.org> wrote:
>
> On Fri, Mar 25, 2016 at 02:10:25PM -0700, ben at skyportsystems.com wrote:
>> From: Ben Warren <ben at skyportsystems.com>
>>
>> Signed-off-by: Ben Warren <ben at skyportsystems.com>
>
> I change the commit message to refer to just "build assertions"; we
> don't spell anything as BLDASSERT.
>
> I don't like comments that define things in terms of history; it makes
> it harder for new people to get up to speed with the current state of a
> code base if they have to learn things in terms of what was once there.
> History is for version control. So I changed this section header to
> just say "Build assertions":
>> +/* Formerly in lib/util.h */
Thanks, Iâll keep that in mind going forward.
>
> Thanks, with those changes I applied this.
regards,
Ben
More information about the dev
mailing list