[ovs-dev] [PATCH] ovs-ofctl.8: commit is required with alg in ct().

Justin Pettit jpettit at ovn.org
Thu Mar 3 17:09:34 UTC 2016


> On Mar 3, 2016, at 7:18 AM, Russell Bryant <russell at ovn.org> wrote:
> 
> The "alg=" argument to the ct() action only makes sense when used in
> combination with "commit".  Add this to the documentation to help make
> it clear.
> 
> Signed-off-by: Russell Bryant <russell at ovn.org>
> ---
> utilities/ovs-ofctl.8.in | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
> index 1b280ef..74b88d8 100644
> --- a/utilities/ovs-ofctl.8.in
> +++ b/utilities/ovs-ofctl.8.in
> @@ -1745,6 +1745,9 @@ connection arrives which is related, the \fBct\fR action will set the
> .RE
> .
> .IP
> +The \fBcommit\fR parameter should be specified to use \fBalg=\fIalg\fR.

RFC-related feedback: Your suggestion sounds nicer, but do you think that should be "must" instead of "should"?  I'm fine either way, though.

Acked-by: Justin Pettit <jpettit at ovn.org>

--Justin





More information about the dev mailing list