[ovs-dev] [PATCH] ovn-controller: add restart test

Russell Bryant russell at ovn.org
Mon Mar 7 21:32:11 UTC 2016


On Mon, Mar 7, 2016 at 4:27 PM, ramu <ramu.ramamurthy at gmail.com> wrote:

>
>
>> Does this depend on your zone-ids fix?  Do you have another rev of that
>> coming?
>>
>
> Russell, This test does not depend on the zone-id fix, because it replaces
> zone-ids on flows
> with a dummy string "xyz". It passes on the master as is.
>
> I will send the next revision of the zone-id fix soon, and as part of that
> fix, this test
> will also be updated to compare zone-ids on flows.
>

I see now.  You even wrote:

+# For now, zone-ids in flows are masked out because, they are not assigned
+# consistently. This test is added to prepare for that code-change.

What I would probably do is submit them together: the zone-ids fix + this
test case that helps test it.  If you take out your "xyz" change, will this
test fail currently?

-- 
Russell Bryant



More information about the dev mailing list