[ovs-dev] [PATCH v3 1/2] datapath: Drop support for kernel older than 3.10

Jesse Gross jesse at kernel.org
Fri Mar 11 21:57:00 UTC 2016


On Mon, Feb 29, 2016 at 9:54 AM, Pravin B Shelar <pshelar at ovn.org> wrote:
> diff --git a/FAQ.md b/FAQ.md
> index 8bd7ab9..12ef2fa 100644
> --- a/FAQ.md
> +++ b/FAQ.md
[...]
>     Open vSwitch userspace is not sensitive to the Linux kernel version.
> -   It should build against almost any kernel, certainly against 2.6.32
> -   and later.
> +   It should build against almost any kernel compatible with the release.

Even after we drop support for compiling the out of tree module on
older kernels, I think that we'll continue to support userspace on
those kernels - for example, it's still possible to run the latest
userspace on a 3.3 kernel with the upstream module or purely in
userspace. As a result, I think we can leave the above sentence as it
is currently.

> diff --git a/INSTALL.md b/INSTALL.md
> index 9c96bbe..3836ec4 100644
> --- a/INSTALL.md
> +++ b/INSTALL.md
> @@ -335,18 +325,6 @@ Building the Sources
>          module loading, please include the output from the `dmesg` and
>          `modinfo` commands mentioned above.

I think only the last reason for the module failing to load is still
possible (compiled for a different kernel).

> diff --git a/acinclude.m4 b/acinclude.m4
> index 11c7787..60890ef 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
[...]
>    OVS_GREP_IFELSE([$KSRC/include/linux/netdevice.h], [netdev_rx_handler_register])
>    OVS_GREP_IFELSE([$KSRC/include/linux/netdevice.h], [net_device_extended])

I don't think either of these symbols are referenced any more.

Otherwise this looks good - we can continue to remove dead code in the
compat directory as time goes on.

Acked-by: Jesse Gross <jesse at kernel.org>



More information about the dev mailing list