[ovs-dev] [RFC 4/8] ovn-northd: Introduce stateful table.

Ben Pfaff blp at ovn.org
Mon Mar 14 17:59:52 UTC 2016


On Sun, Feb 28, 2016 at 10:33:20PM -0800, Gurucharan Shetty wrote:
> Currently, the only use of stateful services in conntrack is
> OVN ACLs. In table ACL, we commit the packet to conntrack
> via ct_commit action.
> 
> As we introduce more stateful services, the ACL feature will
> have to share the conntrack module with others. As
> preparation for more stateful features like NAT and
> loadbalancing, this commit introduces a new stateful table
> that is responsible to commit packets to conntrack via
> ct_commit action. If ACL table needs to commit a packet,
> it sets 'reg1' as 1. Stateful table in-turn will commit
> the packet if 'reg1' is 1.
> 
> Signed-off-by: Gurucharan Shetty <guru at ovn.org>

I am still not sure why STATEFUL is written in all-caps.

We will use up registers very quickly if we use them this way.  It is
easy to use individual bits as flags.  Did you consider using, for
example, reg0[0] and reg0[1] instead of all of reg0 and reg1 for these
hints?

Acked-by: Ben Pfaff <blp at ovn.org>



More information about the dev mailing list