[ovs-dev] [RFC 5/8] ovn-nb: Add Load-balancer table to schema.

Ben Pfaff blp at ovn.org
Tue Mar 15 17:24:53 UTC 2016


On Sun, Feb 28, 2016 at 10:33:21PM -0800, Gurucharan Shetty wrote:
> Also add the ability to run database commands on the
> new schema using ovn-nbctl.
> 
> Signed-off-by: Gurucharan Shetty <guru at ovn.org>

Some of the indentation in ovn/ovn-nb.xml looked a bit funny.  I think
that it might use tabs in some places, whereas that file generally uses
spaces only.

I see that "loadbalancer" is run together into one word in the
documentation in some places.  It looks funny to me like that; I would
prefer to include a space.  It also looks like we usually include an
underscore in the schema for multiple words, so load_balancer might be a
more consistent name there.  (Outside the schema it doesn't bother me
nearly as much, since it's easy to change internal identifiers later.)

I think that it would be helpful for the .xml to give a little more
information on the expected behavior of a load balancer.  It is probably
obvious to people who know load balancers well, but an extra sentence or
two would help the rest of us a bit.

Thanks,

Ben.



More information about the dev mailing list