[ovs-dev] [ovs-dev, v2, 08/23] Move BLDASSERT macros to compiler header file

Ryan Moats rmoats at us.ibm.com
Thu Mar 17 17:04:54 UTC 2016


---- Original Message ----
> From: Ben Warren <ben at skyportsystems.com>
>
> Signed-off-by: Ben Warren <ben at skyportsystems.com>
> ---
>  include/openvswitch/compiler.h | 30 ++++++++++++++++++++++++++++++
>  lib/util.h                     | 28 ----------------------------
>  2 files changed, 30 insertions(+), 28 deletions(-)

I'm not quite comfortable with this one in its current
form as all of the files that imported lib/util.h and
made use of these assert macros that are moving do not
also directly import include/openvswitch/compiler.h.

Since "make check" passes, they obviously get to the
include file via an indirect path, but I feel like
that fact should be pointed out in the commit message...




More information about the dev mailing list