[ovs-dev] [ovs-dev, v2, 09/23] Break tun-metadata.h into private and public parts

Ben Pfaff blp at ovn.org
Mon Mar 21 16:01:55 UTC 2016


On Thu, Mar 17, 2016 at 11:22:13AM -0600, Ryan Moats wrote:
> 
> > From: Ben Warren <ben at skyportsystems.com>
> >
> > Public (struct definitions and some prototypes) go in
> > include/openvswitch
> >
> > Signed-off-by: Ben Warren <ben at skyportsystems.com>
> > ---
> >  include/openvswitch/automake.mk    |   1 +
> >  include/openvswitch/tun-metadata.h | 101 +++++++++++++++++++++++++++++++
> ++++++
> >  lib/tun-metadata.h                 |  80 +----------------------------
> >  3 files changed, 103 insertions(+), 79 deletions(-)
> >  create mode 100644 include/openvswitch/tun-metadata.h
> 
> This is really a nit (and applies wherever you've created a new file
> in this series), but is the copyright on the new file correct?
> Shouldn't it be 2016?  Should the attribution really still be to Nicira?

Moving a file doesn't change the copyright holder (otherwise, all those
people out there sharing music and movies would own the copyrights to
the copies!).  Whoever had copyright before still does, and from the
same years.

If the person who moved it made changes to it and wishes to assert
copyright on those changes, then adding a new copyright license (or
updating the existing one, if the person is already listed) is
appropriate.

Similarly, notices on a file being split in two would be copied into
both parts.  I suppose a case could be made for copying only some
notices, if it were possible to identify that some copyright holder had
only contributed to some part of the original.



More information about the dev mailing list