[ovs-dev] [PATCH v2 04/23] Move contents of lib/list.h to include/openvswitch directory

Ben Pfaff blp at ovn.org
Mon Mar 21 16:22:41 UTC 2016


Thanks.  I'm starting to get too many patch rejects at this point in the
series.

Note that I skipped patch 1.  That's because I still don't see how it is
useful to clients at this point in the series.

On Sat, Mar 19, 2016 at 03:26:22PM -0700, Ben Warren wrote:
> Thanks!  I'll resolve and re-post.
> 
> Sent from my iPhone
> 
> > On Mar 19, 2016, at 9:51 AM, Ben Pfaff <blp at ovn.org> wrote:
> > 
> >> On Thu, Mar 03, 2016 at 10:20:44AM -0800, ben at skyportsystems.com wrote:
> >> From: Ben Warren <ben at skyportsystems.com>
> >> 
> >> Most of the list code is properly namespaced, so is OK to move to the
> >> global export directory.  Some "lib/util.h" code had to move to the
> >> other directory as well, but I've tried to make that as small as
> >> possible
> >> 
> >> Signed-off-by: Ben Warren <ben at skyportsystems.com>
> > 
> > list.h was partially moved already, and as part of that everything moved
> > to the new location was namespaced under ovs_.  I'm a little reluctant
> > to re-pollute the namespace given that some care was taken already.  I'm
> > not saying that name fixups have to happen before the move can be made,
> > but I'd like to at least do them in a commit that I can put in right
> > after the move.
> > 
> > I also get a compiler error here:
> > 
> > ../tests/test-list.c:191:5: error: implicitly declaring library function 'printf' with type 'int (const char *, ...)' [-Werror]
> >    printf(".");
> >    ^
> > ../tests/test-list.c:191:5: note: include the header <stdio.h> or explicitly provide a declaration for 'printf'
> > 1 error generated.
> > 





More information about the dev mailing list