[ovs-dev] [PATCH] ovn-controller: add restart test

Ben Pfaff blp at ovn.org
Tue Mar 22 17:47:39 UTC 2016


On Mon, Mar 07, 2016 at 04:03:56PM -0500, Ramu Ramamurthy wrote:
> Add a test to validate that a restart of the ovn-controller
> will program flows in table 0 consistently. Flows before
> restart are compared against flows after restart to detect
> problems with ofports or zone-ids.
> 
> Signed-off-by: Ramu Ramamurthy <ramu.ramamurthy at us.ibm.com>

This adds a test for this invariant for a specific test case, which is
useful.  However, I believe that this should be a universal invariant
for ovn-controller, so that at any time if ovn-controller is restarted
gracefully after it has converged, it should preserve these flows.  Is
that true?  If so, then it would be more useful to add such a check to
*every* test case for OVN.

What do you think?

Thanks,

Ben.



More information about the dev mailing list