[ovs-dev] [PATCH v1] bridge: Fix qos_unixctl_show bug.

Ben Pfaff blp at ovn.org
Tue Mar 22 17:58:50 UTC 2016


On Tue, Mar 08, 2016 at 11:10:31PM +0000, Ian Stokes wrote:
> netdev_get_qos returns a value to indicate if an error has occurred while
> attempting to query the QoS configuration of an interface. If an error does
> occur the pointer argument passed to it will be set to null before returning.
> Currently the vswitch will segfault if this occurs as qos_unixctl_show will
> attempt to access the pointer directly after it calls netdev_get_qos.
> 
> Avoid this by adding a check for the return value and flagging an appropriate
> error message to appctl and the vswitch log.
> 
> Signed-off-by: Ian Stokes <ian.stokes at intel.com>

Thanks!  I applied this to master, branch-2.5, branch-2.4, and
branch-2.3.



More information about the dev mailing list