[ovs-dev] [PATCH v2 6/7] netdev: remove netdev_get_in4()
Ben Pfaff
blp at ovn.org
Wed Mar 23 15:33:51 UTC 2016
On Tue, Mar 15, 2016 at 09:57:32AM -0700, Pravin B Shelar wrote:
> Since netdev can have multiple IP address use
> generic api netdev_get_addr_list(). This also make it
> easier to handle IPv4 and IPv6 address across vswitchd
> layers.
>
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
> @@ -740,7 +734,7 @@ netdev_linux_update(struct netdev_linux *dev,
> if (change->nlmsg_type == RTM_NEWLINK) {
Could use a comment update here:
> /* Keep drv-info, in4, in6. */
> netdev_linux_changed(dev, change->ifi_flags,
> - VALID_DRVINFO | VALID_IN4 | VALID_IN6);
> + VALID_DRVINFO | VALID_IN);
>
> /* Update netdev from rtnl-change msg. */
> if (change->mtu) {
Deleting code is nice, thanks.
Acked-by: Ben Pfaff <blp at ovn.org>
More information about the dev
mailing list