[ovs-dev] [PATCH] Use southbound database when saying Binding table

[Russell Bryant]

On Wed, Mar 23, 2016 at 4:04 PM, Ben Pfaff <blp at ovn.org> wrote:

> On Wed, Mar 23, 2016 at 06:36:29PM +0000, Hui Kang wrote:
> >
> >
> >
> >     ----- Original message -----
> >     From: Ben Pfaff <blp at ovn.org>
> >     To: Hui Kang <hkang.sunysb at gmail.com>
> >     Cc: dev at openvswitch.org, Hui Kang/Watson/IBM at IBMUS
> >     Subject: Re: [ovs-dev] [PATCH] Use southbound database when saying
> Binding
> >     table
> >     Date: Wed, Mar 23, 2016 2:22 PM
> >
> >     On Wed, Mar 23, 2016 at 02:00:32PM -0400, Hui Kang wrote:
> >     > For the sake of clarity
> >     >
> >     > Signed-off-by: Hui Kang <kangh at us.ibm.com>
> >     > ---
> >     >  ovn/ovn-architecture.7.xml | 4 ++--
> >     >  1 file changed, 2 insertions(+), 2 deletions(-)
> >     >
> >     > diff --git a/ovn/ovn-architecture.7.xml
> b/ovn/ovn-architecture.7.xml
> >     > index 13acaf5..659c599 100644
> >     > --- a/ovn/ovn-architecture.7.xml
> >     > +++ b/ovn/ovn-architecture.7.xml
> >     > @@ -354,8 +354,8 @@
> >     >        destined to the new port's MAC address should be delivered
> to it,
> >     and
> >     >        update the flow that delivers broadcast and multicast
> packets to
> >     include
> >     >        the new port.  It also creates a record in the
> <code>Binding</
> >     code> table
> >     > -      and populates all its columns except the column that
> identifies
> >     the
> >     > -      <code>chassis</code>.
> >     > +      of the Southbound database and populates all its columns
> except
> >     the
> >     > +      column that identifies the <code>chassis</code>.
> >
> >     This would be a better clarification if it corrected the name of the
> >     table.
> >
> >
> > Hi, Ben,
> > Thanks for your reply to my very first patch to OVS. Do you mean a
> different
> > name rather than Binding table?
>
> I mean, there is no table named Binding.  The southbound database has
> Port_Binding, Datapath_Binding, and MAC_Binding.


The docs also use a convention that you could adopt in this patch for
referring to databases/tables/columns.  In this case:

... a record in the <ref db="OVN_Southbound" table="Port_Binding"/> table
of the <ref db="OVN_Southbound"/> database ...

-- 
Russell Bryant