[ovs-dev] [PATCH v11 1/1] Separating OVN NB and SB database processes

[Guru Shetty]

I saw the following 3 issues when I did a git pull today. It is possible
that I am not doing something the "new" way.

1.
root at ovn1:~/git/routes# /usr/share/openvswitch/scripts/ovn-ctl
restart_northd
 * Exiting ovn-northd (30705)
2016-03-24T10:56:44Z|00001|unixctl|WARN|failed to connect to
/var/run/openvswitch/ovnnb_db.30694.ctl
ovs-appctl: cannot connect to "/var/run/openvswitch/ovnnb_db.30694.ctl" (No
such file or directory)
2016-03-24T10:56:44Z|00001|unixctl|WARN|failed to connect to
/var/run/openvswitch/ovnsb_db.30700.ctl
ovs-appctl: cannot connect to "/var/run/openvswitch/ovnsb_db.30700.ctl" (No
such file or directory)
 * Starting ovn-northd

I think the above needs the following incremental.
diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl
index 4348d6e..fb39754 100755
--- a/ovn/utilities/ovn-ctl
+++ b/ovn/utilities/ovn-ctl
@@ -37,11 +37,11 @@ pidfile_is_running () {

 stop_ovsdb () {
     if pidfile_is_running $DB_NB_PID; then
-        ovs-appctl -t ovnnb_db exit
+        ovs-appctl -t $OVN_DIR/ovnnb_db exit
     fi

     if pidfile_is_running $DB_SB_PID; then
-        ovs-appctl -t ovnsb_db exit
+        ovs-appctl -t $OVN_DIR/ovnsb_db exit
     fi
 }

I think it is unfortunate that we will have to run the commands of the
following form in the future for runtime information:

ovs-appctl -t /var/run/openvswitch/ovnnb_db ovsdb-server/list-remotes

But I guess, I will get used to it.

2. The ovsdb-server daemons are getting started with --log-file set to "/"
. For e.g:
ovsdb-server --detach -vconsole:off --log-file=/ovsdb-server-nb.log

3. The databases are being created in /var/run/openvswitch

That feels like an odd place to keep databases. We have been keeping it in
/etc/openvswitch so far.

On 23 March 2016 at 17:11, Russell Bryant <russell at ovn.org> wrote:

> On Wed, Mar 23, 2016 at 5:05 PM, Ben Pfaff <blp at ovn.org> wrote:
>
> > On Mon, Mar 21, 2016 at 03:40:01PM -0500, Ryan Moats wrote:
> > > From: RYAN D. MOATS <rmoats at us.ibm.com>
> > >
> > > OVN NB & SB DB's should be run in separate ovsdb-server processes
> > > and should run with ovn-ctl start_northd / stop_northd.  This patch
> > > includes changes to unit tests, tutorial and debian scripts to remain
> > > self-consistent.
> > >
> > > Signed-off-by: RYAN D. MOATS <rmoats at us.ibm.com>
> > > Signed-off-by: Michael Arnaldi <arnaldimichael at gmail.com>
> >
> > This seems OK to me.
> >
> > From our IRC conversation, it sounds like there should be a
> > Co-authored-by for Michael Arnaldi.
> >
> > Since Russell has taken the lead on this I'll leave the final review and
> > apply to him.
> >
>
> Thanks for working on this Michael and Ryan!  The latest version looked
> good to me.  I applied it to master with the following minor changes: a
> whitespace fix, adding Michael to AUTHORS, and removing duplicate help
> text.
>
> diff --git a/AUTHORS b/AUTHORS
> index 9e44e4c..f0d1e23 100644
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -141,6 +141,7 @@ Martino Fornasa         mf at fornasa.it
>  Maryam Tahhan           maryam.tahhan at intel.com
>  Mauricio Vásquez        mauricio.vasquezbernal at studenti.polito.it
>  Mehak Mahajan           mmahajan at nicira.com
> +Michael Arnaldi         arnaldimichael at gmail.com
>  Michal Weglicki         michalx.weglicki at intel.com
>  Mijo Safradin           mijo at linux.vnet.ibm.com
>  Minoru TAKAHASHI        takahashi.minoru7 at gmail.com
> diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl
> index 9dbaa64..4348d6e 100755
> --- a/ovn/utilities/ovn-ctl
> +++ b/ovn/utilities/ovn-ctl
> @@ -230,7 +230,6 @@ Options:
>                                     this is set to "no", the "start_ovsdb"
> and
>                                     "stop_ovsdb" commands must be used to
> start
>                                     and stop the OVN databases.
> -  --ovn-manage-ovsdb=no              manage ovsdb separately from
> start_northd and stop_northd
>    --ovn-controller-log=STRING        ovn controller process logging params
> (default: $OVN_CONTROLLER_LOG)
>    --ovn-northd-log=STRING            ovn northd process logging params
> (default: $OVN_NORTHD_LOG)
>    --ovn-nb-log=STRING             ovn NB ovsdb-server processes logging
> params (default: $OVN_NB_LOG)
> diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox
> index 51e3a9f..f331a00 100755
> --- a/tutorial/ovs-sandbox
> +++ b/tutorial/ovs-sandbox
> @@ -365,7 +365,7 @@ if $ovn; then
>          --ovnsb-db=unix:"$sandbox"/ovnsb_db.sock \
>          --ovnnb-db=unix:"$sandbox"/ovnnb_db.sock
>      rungdb $gdb_ovn_controller $gdb_ovn_controller_ex ovn-controller \
> -        --detach --no-chdir --pidfile -vconsole:off --log-file
> +        --detach --no-chdir --pidfile -vconsole:off --log-file
>      rungdb $gdb_ovn_controller_vtep $gdb_ovn_controller_vtep_ex \
>          ovn-controller-vtep --detach --no-chdir --pidfile -vconsole:off \
>          --log-file --ovnsb-db=unix:"$sandbox"/ovnsb_db.sock
>
>
> --
> Russell Bryant
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>