[ovs-dev] [PATCH v11 1/1] Separating OVN NB and SB database processes

[Guru Shetty]

On 24 March 2016 at 14:16, Russell Bryant <russell at ovn.org> wrote:

>
>
> On Thu, Mar 24, 2016 at 4:56 PM, Guru Shetty <guru at ovn.org> wrote:
>
>> I saw the following 3 issues when I did a git pull today. It is possible
>> that I am not doing something the "new" way.
>>
>
> Sorry for the trouble.
>
>
>> 1.
>> root at ovn1:~/git/routes# /usr/share/openvswitch/scripts/ovn-ctl
>> restart_northd
>>  * Exiting ovn-northd (30705)
>> 2016-03-24T10:56:44Z|00001|unixctl|WARN|failed to connect to
>> /var/run/openvswitch/ovnnb_db.30694.ctl
>> ovs-appctl: cannot connect to "/var/run/openvswitch/ovnnb_db.30694.ctl"
>> (No such file or directory)
>> 2016-03-24T10:56:44Z|00001|unixctl|WARN|failed to connect to
>> /var/run/openvswitch/ovnsb_db.30700.ctl
>> ovs-appctl: cannot connect to "/var/run/openvswitch/ovnsb_db.30700.ctl"
>> (No such file or directory)
>>  * Starting ovn-northd
>>
>> I think the above needs the following incremental.
>> diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl
>> index 4348d6e..fb39754 100755
>> --- a/ovn/utilities/ovn-ctl
>> +++ b/ovn/utilities/ovn-ctl
>> @@ -37,11 +37,11 @@ pidfile_is_running () {
>>
>>  stop_ovsdb () {
>>      if pidfile_is_running $DB_NB_PID; then
>> -        ovs-appctl -t ovnnb_db exit
>> +        ovs-appctl -t $OVN_DIR/ovnnb_db exit
>>      fi
>>
>>      if pidfile_is_running $DB_SB_PID; then
>> -        ovs-appctl -t ovnsb_db exit
>> +        ovs-appctl -t $OVN_DIR/ovnsb_db exit
>>      fi
>>  }
>>
>> I think it is unfortunate that we will have to run the commands of the
>> following form in the future for runtime information:
>>
>> ovs-appctl -t /var/run/openvswitch/ovnnb_db ovsdb-server/list-remotes
>>
>> But I guess, I will get used to it.
>>
>
> I thought it was changed to make "-t ovnnb_db" and "-t ovnsb_db" work.
> Sorry... I think we should fix the root cause.  We can merge your fix in
> the meantime though.
>
>
>
>> 2. The ovsdb-server daemons are getting started with --log-file set to
>> "/" . For e.g:
>> ovsdb-server --detach -vconsole:off --log-file=/ovsdb-server-nb.log
>>
>
> Badness.
>
> I think that needs:
>
> diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl
> index 4348d6e..e535561 100755
> --- a/ovn/utilities/ovn-ctl
> +++ b/ovn/utilities/ovn-ctl
> @@ -182,8 +182,8 @@ set_defaults () {
>      OVN_NORTHD_LOG="-vconsole:emer -vsyslog:err -vfile:info"
>      OVN_NB_LOG="-vconsole:off"
>      OVN_SB_LOG="-vconsole:off"
> -    OVN_NB_LOGFILE="$OVS_LOGDIR/ovsdb-server-nb.log"
> -    OVN_SB_LOGFILE="$OVS_LOGDIR/ovsdb-server-sb.log"
> +    OVN_NB_LOGFILE="ovsdb-server-nb.log"
> +    OVN_SB_LOGFILE="ovsdb-server-sb.log"
>  }
>
>  set_option () {
>
>
>
>
>> 3. The databases are being created in /var/run/openvswitch
>>
>> That feels like an odd place to keep databases. We have been keeping it
>> in /etc/openvswitch so far.
>>
>
> Yes.  I missed that default change.  It used to be $dbdir, and changed
> default to $rundir.
>
>
> I can post a patch to clean this up, but I was hoping to figure out issue
> #1 first.
>
Oh please take your time. I was not sure whether I was doing it the way it
was supposed to be done. As long as this is something you see too, then
this does not really block me. It is just in master, so it is all okay.


>
> --
> Russell Bryant
>