[ovs-dev] [PATCH] datapath-windows: Remove unnecessary keylen computation in Flow.c
Sairam Venugopal
vsairam at vmware.com
Fri Mar 25 18:41:44 UTC 2016
destKey->l2.keylen gets reset after this line. This change
doesn't help with hash computation and can be removed. This is what
destKey->l2.keyLen gets set to:
destKey->l2.keyLen = OVS_WIN_TUNNEL_KEY_SIZE + OVS_L2_KEY_SIZE
- destKey->l2.offset;
Signed-off-by: Sairam Venugopal <vsairam at vmware.com>
---
datapath-windows/ovsext/Flow.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index d49697c..004c54a 100644
--- a/datapath-windows/ovsext/Flow.c
+++ b/datapath-windows/ovsext/Flow.c
@@ -1382,12 +1382,10 @@ _MapKeyAttrToFlowPut(PNL_ATTR *keyAttrs,
if (keyAttrs[OVS_KEY_ATTR_RECIRC_ID]) {
destKey->recircId = NlAttrGetU32(keyAttrs[OVS_KEY_ATTR_RECIRC_ID]);
- destKey->l2.keyLen += sizeof(destKey->recircId);
}
if (keyAttrs[OVS_KEY_ATTR_DP_HASH]) {
destKey->dpHash = NlAttrGetU32(keyAttrs[OVS_KEY_ATTR_DP_HASH]);
- destKey->l2.keyLen += sizeof(destKey->dpHash);
}
/* ===== L2 headers ===== */
--
2.5.0.windows.1
More information about the dev
mailing list