[ovs-dev] [PATCH_v5 08/26] Misc cleanup with "util.h" header files

Ben Pfaff blp at ovn.org
Wed Mar 30 20:33:49 UTC 2016


On Fri, Mar 25, 2016 at 02:10:27PM -0700, ben at skyportsystems.com wrote:
> From: Ben Warren <ben at skyportsystems.com>
> 
> Removed from redundant #includes and moved some macros to different file
> scope
> 
> Signed-off-by: Ben Warren <ben at skyportsystems.com>
> Acked-by: Ryan Moats <rmoats at us.ibm.com>

With this applied I get pervasive warnings like this:

    /usr/lib/gcc/i586-linux-gnu/4.9//include/stdarg.h:51:9: warning: preprocessor token va_copy redefined
    ../lib/util.h:33:9: this was the original definition

I think that probably this is due to defining va_copy before #including
<stdarg.h>, but I haven't looked.

I feel like it's a good idea to let the changes that I've already
applied percolate through everyone's build systems, etc. for a while, so
I'm going to leave off with this series for now.  When you've had a
chance to look at this problem, please post a v6.



More information about the dev mailing list