[ovs-dev] [PATCH v12 1/9] Fix missing tracking reording of row deletes.

Ryan Moats rmoats at us.ibm.com
Wed Mar 30 21:35:58 UTC 2016


From: RYAN D. MOATS <rmoats at us.ibm.com>

Deletes need to be reordered as well as inserts and modifies,
otherwise, following tracked changes will see out of order
seqnos.

Signed-off-by: RYAN D. MOATS <rmoats at us.ibm.com>
---
 lib/ovsdb-idl.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index bfc133b..84ce14e 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -1589,9 +1589,10 @@ ovsdb_idl_row_destroy(struct ovsdb_idl_row *row)
                 = row->table->change_seqno[OVSDB_IDL_CHANGE_DELETE]
                 = row->table->idl->change_seqno + 1;
         }
-        if (list_is_empty(&row->track_node)) {
-            list_push_back(&row->table->track_list, &row->track_node);
+        if (!list_is_empty(&row->track_node)) {
+            list_remove(&row->track_node);
         }
+        list_push_back(&row->table->track_list, &row->track_node);
     }
 }
 
-- 
1.7.1




More information about the dev mailing list