[ovs-dev] [PATCHv2 1/2] ofproto-dpif-xlate: Fix bitwise ops on ct_mark.

[Ben Pfaff]

On Thu, Mar 31, 2016 at 12:21:13AM +1300, Joe Stringer wrote:
> Using the action ct(commit,set_field:0x1/0x1->ct_mark), ie, specifying a
> mask, would previously overwrite the entire ct_mark field rather than
> modifying only the specified bits. Fix the issue.
> 
> Fixes: 8e53fe8cf7a1 ("Add connection tracking mark support.")
> Signed-off-by: Joe Stringer <joe at ovn.org>
> ---
> v2: Remove wildcards from put_ct_mark().

I didn't test this but it looks good and compiles cleanly.

A possible (though unnecessary) enhancement to the test would be to
verify that setting a bit to 0 also works.

Acked-by: Ben Pfaff <blp at ovn.org>