[ovs-dev] [PATCHv2 2/2] ofproto-dpif-xlate: Fix bitwise ops on ct_labels.

[Ben Pfaff]

On Thu, Mar 31, 2016 at 12:21:14AM +1300, Joe Stringer wrote:
> Using the action ct(commit,set_field:0x1/0x1->ct_label), ie, specifying
> a mask, would previously overwrite the entire ct_labels field rather than
> modifying only the specified bits. Fix the issue.
> 
> Fixes: 9daf23484fb1 ("Add connection tracking label support.")
> Signed-off-by: Joe Stringer <joe at ovn.org>

The following expressions would look more symmetrical if the order of
the arguments in the call to ovs_u128_xor() were swapped:
> +        odp_ct_label->mask = ovs_u128_xor(base_flow->ct_label, flow->ct_label);
> +        odp_ct_label->key = ovs_u128_and(flow->ct_label, odp_ct_label->mask);
>      }
>  }

Thanks, this looks good to me.  Again, I compiled it but I did not test
it.

Acked-by: Ben Pfaff <blp at ovn.org>