[ovs-dev] [PATCH v10 3/5] userspace: add layer 3 support to packet metadata

Simon Horman simon.horman at netronome.com
Wed Jun 1 02:19:19 UTC 2016


On Tue, May 31, 2016 at 01:52:55PM -0700, Ben Pfaff wrote:
> On Wed, May 04, 2016 at 04:34:23PM +0900, Simon Horman wrote:
> > From: Lorand Jakab <lojakab at cisco.com>
> > 
> > This is needed for sending a packet back to the datapath after a miss
> > upcall was processed.  The presence of a layer 2 packet is signaled by
> > adding OVS_KEY_ATTR_ETHERNET to the packet metadata sent with the
> > ovs_packet netlink message.  Layer 3 packets need to be accompanied by
> > OVS_KEY_ATTR_PACKET_ETHERTYPE to indicate network protocol.
> > 
> > Signed-off-by: Lorand Jakab <lojakab at cisco.com>
> > Signed-off-by: Simon Horman <simon.horman at netronome.com>
> 
> I am not sure it makes sense to do a masked set of a packet Ethertype
> (in odp_execute_masked_set_action()).

Thanks. I'm not sure that we need to allow set of packet Ethernet at all.
It does seem that its not necessary to do something useful with l3 tunnels
at this time. So I've removed it for now.

> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks!


More information about the dev mailing list