[ovs-dev] [PATCH] netdev-dpdk: print default vhost-sock-dir if none provided

[Loftus, Ciara]

> Hi Ciara,
> 
> Please add a Fixes: tag.
> 
> Ciara Loftus <ciara.loftus at intel.com> writes:
> 
> > Signed-off-by: Ciara Loftus <ciara.loftus at intel.com>
> > ---
> >  lib/netdev-dpdk.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> > index b488c60..67b9e0d 100644
> > --- a/lib/netdev-dpdk.c
> > +++ b/lib/netdev-dpdk.c
> > @@ -2982,7 +2982,7 @@ dpdk_init__(const struct smap
> *ovs_other_config)
> >      if (process_vhost_flags("cuse-dev-name", xstrdup("vhost-net"),
> >                              PATH_MAX, ovs_other_config, &cuse_dev_name)) {
> >  #else
> > -    if (process_vhost_flags("vhost-sock-dir", xstrdup(""),
> > +    if (process_vhost_flags("vhost-sock-dir", xstrdup(ovs_rundir()),
> >                              NAME_MAX, ovs_other_config,
> >                              &sock_dir_subcomponent)) {
> >          struct stat s;
> 
> Please include this (untested) hunk (or something like it):
> 
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index b488c60..4edf18b 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -3003,8 +3003,7 @@ dpdk_init__(const struct smap *ovs_other_config)
>          }
>          free(sock_dir_subcomponent);
>      } else {
> -        vhost_sock_dir = xstrdup(ovs_rundir());
> -        free(sock_dir_subcomponent);
> +        vhost_sock_dir = sock_dir_subcomponent;
>  #endif

Hi Aaron,

Thanks for the suggestions. I've updated and send a v2 with an update to the documentation too.

Thanks,
Ciara