[ovs-dev] [PATCH] debian, rhel: Ship ovs shared libraries and header files

[Ben Pfaff]

On Tue, Apr 26, 2016 at 02:32:33PM -0300, Flavio Leitner wrote:
> On Fri, Apr 15, 2016 at 01:28:18PM -0700, echiu at vmware.com wrote:
> > From: Edwin Chiu <echiu at vmware.com>
> > 
> > Compile and package ovs shared libraries and create new header
> > package for debian (openvswitch-dev) and rhel (openvswitch-devel).
> > 
> > VMware-BZ: #1556299
> > Signed-off-by: Edwin Chiu <echiu at vmware.com>
> > Co-authored-by: Harold Lim <haroldl at vmware.com>

> > +copy_headers include $LOCAL_INCLUDE/openvswitch
> > +copy_headers include/openflow $LOCAL_INCLUDE/openvswitch/openflow
> > +copy_headers include/openvswitch $LOCAL_INCLUDE/openvswitch/openvswitch
> > +copy_headers include/sparse $LOCAL_INCLUDE/openvswitch/sparse
> > +copy_headers include/sparse/arpa $LOCAL_INCLUDE/openvswitch/sparse/arpa
> > +copy_headers include/sparse/netinet $LOCAL_INCLUDE/openvswitch/sparse/netinet
> > +copy_headers include/sparse/sys $LOCAL_INCLUDE/openvswitch/sparse/sys
> > +copy_headers lib $LOCAL_INCLUDE/openvswitch/lib
> 
> You are copying the headers to /usr/local/include. Usually we avoid
> doing that because /usr/local is reserved for local stuff that the admin
> could have built/installed manually.
> 
> For instance, you could install the RPM and still compile upstream OVS
> which by default installs itself in /usr/local.  However, after this patch
> there would be an unexpected conflict.

I second this remark.  Debian policy is specific about /usr/local:

9.1.2. Site-specific programs
-----------------------------

     As mandated by the FHS, packages must not place any files in
     `/usr/local', either by putting them in the file system archive to be
     unpacked by `dpkg' or by manipulating them in their maintainer
     scripts.

> Also that you moved the files to be inside openvswitch/ which looks
> good but then you need to fix the .pc files otherwise they will refer
> to the old (and invalid %{_includedir}).  I guess the same problem
> would happen with the debian version.

Yes, I think you're right.