[ovs-dev] [PATCH 3/3] ovn-nbctl: Add sanity checking for lswitch-add.

Ben Pfaff blp at ovn.org
Sun May 8 16:25:51 UTC 2016


On Sat, May 07, 2016 at 04:44:27PM -0700, Justin Pettit wrote:
> 
> > On May 6, 2016, at 1:10 PM, Ben Pfaff <blp at ovn.org> wrote:
> > 
> > +      <dt><code>lswitch-add</code> [<var>lswitch</var>]</dt>
> > +      <dd>
> > +        <p>
> > +          Creates a new, unnamed logical switch, which initially has no ports.
> > +          The switch does not have a name, other commands must refer to this
> > +          switch by its UUID.
> > +        </p>
> > +      </dd>
> 
> Don't you want to drop "[<var>lswitch</var>]" from the description for
> adding an unnamed switch?

Yes, thanks, done.

> > +      <dt>[<code>--if-exists</code>] <code>lswitch-del</code> <var>lswitch</var></dt>
> 
> The code for "--if-exists" was introduced in the previous patch.
> 
> > +      <dt>[<code>--may-exist</code>] <code>lport-add</code> <var>lswitch</var> <var>lport</var></dt>
> 
> The code for "--may-exist" was introduced in the previous patch.
> 
> > +      <dt>[<code>--if-exists</code>] <code>lport-del</code> <var>lport</var></dt>
> 
> The code for "--if-exists" was introduced in the previous patch.

Thanks for pointing those out.  I have moved these documentation updates
to the previous patch.

> > @@ -538,7 +565,6 @@ nbctl_lport_add(struct ctl_context *ctx)
> >     const struct nbrec_logical_switch *lswitch;
> >     lswitch = lswitch_by_name_or_uuid(ctx, ctx->argv[1], true);
> > 
> > -
> 
> This was introduced in the previous patch.

Thanks, fixed.

> Acked-by: Justin Pettit <jpettit at ovn.org>

Thanks, I'll apply patches 2 and 3, with corrections, in a few minutes.



More information about the dev mailing list