[ovs-dev] [patch_v10] vtep: add source node replication support.

Justin Pettit jpettit at ovn.org
Wed May 11 23:20:06 UTC 2016


> On May 10, 2016, at 4:07 PM, Darrell Ball <dlu998 at gmail.com> wrote:
> 
> 
> 
> On Tue, May 10, 2016 at 1:39 PM, Justin Pettit <jpettit at ovn.org> wrote:
> 
> > On May 7, 2016, at 9:21 AM, Darrell Ball <dlu998 at gmail.com> wrote: 
> 
> > diff --git a/vtep/README.ovs-vtep.md b/vtep/README.ovs-vtep.md
> > index 6734dab..14477e7 100644
> > --- a/vtep/README.ovs-vtep.md
> > +++ b/vtep/README.ovs-vtep.md
> > @@ -166,13 +166,37 @@ vtep-ctl bind-ls br0 p0 0 ls0
> > vtep-ctl set Logical_Switch ls0 tunnel_key=33
> >       ```
> >
> > -3. Direct unknown destinations out a tunnel:
> > +3. Direct unknown destinations out a tunnel.
> > +For handling L2 broadcast, multicast and unknown unicast traffic, packets
> 
> I'd merge that first sentence into the rest of the paragraph.
> 
> That looks inconsistent with the rest of the list and pretty ugly with the
> list item having no title per se.
> Its not my first choice but if that going to block the commit, then sure.

It seems consistent to me, but I'm okay with making it it's own paragraph.  However, the way it was originally written would have caused it to merge into one paragraph when shown in a markdown viewer.  My change was just making it consistent between the raw text and a viewer.  How about the following, which is what I think you'd intended?

+3. Direct unknown destinations out a tunnel.
+
+   For handling L2 broadcast, multicast and unknown unicast traffic,
+   packets can be sent to all members of a logical switch referenced by
+   a physical switch.  The "unknown-dst" address below is used to
+   represent these packets.  There are different modes to replicate the
+   packets.  The default mode of replication is to send the traffic to a
+   service node, which can be a hypervisor, server or appliance, and let
+   the service node handle replication to other transport nodes
+   (hypervisors or other VTEP physical switches).  This mode is called
+   _service node_ replication.  An alternate mode of replication, called
+   _source node_ replication, involves the source node sending to all
+   other transport nodes.  Hypervisors are always responsible for doing
+   their own replication for locally attached VMs in both modes.
+   Service node mode is the default.  Service node replication mode is
+   considered a basic requirement because it only requires sending the
+   packet to a single transport node.  The following configuration is
+   for service node replication mode as only a single transport node
+   destination is specified for the unknown-dst address:

> > +4. Optionally, change the replication mode from a default of service_node to
> > +   source_node, which can be done at the logical switch level:
> 
> The "_" are used to indicate italics, so these modes don't show up properly in a markdown viewer.  You probably want to escape them.
> 
> I've found this markdown previewer to be handy:
> 
>         http://tmpvar.com/markdown.html
> 
> 
> hmm; I thought retext and my browsers would have caught that formatting
> I tried the one you pointed to now - thats useful - "_thanks_"

With the above change, are you okay with my other suggested changes?  Should I push the patch?

--Justin





More information about the dev mailing list