[ovs-dev] [PATCH 2/3] ovn test: remove check for non-existing bridge in hv3

Flavio Fernandes flavio at flaviof.com
Mon May 16 22:35:46 UTC 2016


In OVN vtep test, the network topology is like this:

  hv1---\
         >-- [net1] <-- vtep --> [net2] <-- hv3
  hv2---/

The logical switch lsw0 created in this test has no logical
port corresponding to hv3, so that hypervisor does not have
any bridges created by OVN. With this test change, we are
replacing the 'show br-int' with a check to ensure that
'br-int' is not present.

The improper check for br-int in hv3 appears to have been
inadvertently merged via this commit:
https://github.com/openvswitch/ovs/commit/8dab1022
---
 tests/ovn.at | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/ovn.at b/tests/ovn.at
index 75f7441..1127cea 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -1186,8 +1186,10 @@ as hv2 ovs-ofctl -O OpenFlow13 dump-flows br-int
 
 echo "------ hv3 dump ------"
 as hv3 ovs-vsctl show
-as hv3 ovs-ofctl show br-int
-as hv3 ovs-ofctl -O OpenFlow13 dump-flows br-int
+# note: hv3 has no logical port bind, thus it should not have br-int
+AT_CHECK([as hv3 ovs-ofctl -O OpenFlow13 show br-int], [1], [],
+[ovs-ofctl: br-int is not a bridge or a socket
+])
 
 # Now check the packets actually received against the ones expected.
 for i in 1 2 3; do
-- 
1.9.1




More information about the dev mailing list