[ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

[Ben Pfaff]

On Tue, May 17, 2016 at 11:28:38AM -0700, Joe Stringer wrote:
> On 17 May 2016 at 07:44, Ben Pfaff <blp at ovn.org> wrote:
> > The ofport member should be an ofp_port_t, since it represents an OpenFlow
> > port number.
> >
> > Fixes: 9baaabfff3c7 ("ovn: Fix localnet ports deletion and recreation sometimes after restart.")
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> 
> Thanks, this fixes the issue for me.
> 
> Acked-by: Joe Stringer <joe at ovn.org>

Thanks.

> As a side note for anyone interested, with a little git config item:
> [pretty]
> fixes = Fixes: %h (\"%s\")
> 
> Plus a simple bash function:
> https://github.com/joestringer/config/blob/e66ccc6be698b25237e3e21d4b25ecf168bc9e98/.bashrc#L255-284
> 
> You can run something like "git-fixes-amend <commitid>" after signing
> off a commit and it'll put this tag in there for you.

That's a good idea.

I use a script:

    #! /bin/sh
    git --no-pager log -1 --pretty=format:"Fixes: %h (\"%s\")%n" --abbrev=12 "$@"

and cut-and-paste manually.