[ovs-dev] New Group Mod command to add or modify group

[Ben Pfaff]

That seems reasonable to me.  I suggest posting the patch; we can
quibble about details at that point.

On Thu, May 19, 2016 at 12:28:00PM +0200, Jan Scheurich wrote:
> I have a patch prepared that adds a new group mod command OFPGC11_ADD_OR_MOD (value 0x8000 to not conflict with standard OFPGC commands) to the openflow header files.
>  
> When ofproto.c receives such a group_mod it checks the existence of the referred group_id and either calls add_group() or modify_group().
>  
> To invoke the new command from ovs-ofctl I have added a commands "write-group(s)" that act exactly as add-group(s) except that they do not throw errors if a group already exist.
>  
> Names can of course be discussed and changed.
>  
> > -----Original Message-----
> > From: Ben Pfaff [mailto:blp at ovn.org]
> >
> > On Wed, May 11, 2016 at 01:30:58PM +0000, Jan Scheurich wrote:
> > > A simple solution to this problem would be an additional, more
> > > tolerant Group Mod command (e.g. ADD_OR_MODIFY) that writes a group
> > > into the group table no matter if it already existed in the switch or
> > > not. A similar proposal was submitted to ONF a while ago but never
> > > implemented in the OpenFlow standard
> > > (https://rs.opennetworking.org/bugs/browse/EXT-41[https://rs.opennetworking.org/bugs/browse/EXT-41]).
> > >
> > > Would the OVS community be open to implement this additional Group
> > Mod
> > > command for OpenFlow protocol 1.3 and later?
> >
> > It would be OK with me.  Maybe you should outline how you'd like to do it.