[ovs-dev] [PATCH 3/4] dpif: Pass flow parameter to dpif_execute().

Ben Pfaff blp at ovn.org
Fri May 20 04:01:27 UTC 2016


On Tue, May 17, 2016 at 10:31:24PM -0700, Daniele Di Proietto wrote:
> All the callers of the function already have a copy of the extracted
> flow in their stack (or a few frames before).
> 
> This is useful for different resons:
> * It forces the callers to also call flow_extract() on the packet, which
>   is necessary to initialize the l2,l3,l4 pointers.
> * It will be used in the userspace datapath to generate the RSS hash by
>   a following commit
> * It can be used by the userspace connection tracker to avoid extracting
>   the l3 type again.
> 
> Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>

Good spotting.

This had rejects due to recent changes in dpif.c but it looks OK, so:
Acked-by: Ben Pfaff <blp at ovn.org>



More information about the dev mailing list