[ovs-dev] [PATCH 3/4] ovn-controller-vtep.at: Pre-sort output before feeding to "sort -d"

Takashi YAMAMOTO yamamoto at ovn.org
Fri May 20 06:15:06 UTC 2016


On Fri, May 20, 2016 at 2:30 PM, Takashi YAMAMOTO <yamamoto at ovn.org> wrote:

>
>
> On Fri, May 20, 2016 at 12:45 PM, Ben Pfaff <blp at ovn.org> wrote:
>
>> On Wed, May 18, 2016 at 03:30:30AM +0900, YAMAMOTO Takashi wrote:
>> > NetBSD's "sort -d" preserves the order of lines which doesn't have
>> > alphanumeric and blanks.  eg. empty lines and [].
>> > It means it sometimes preserve unstable order of the list output.
>> >
>> > Also, simply remove -d option where the expected output doesn't
>> > include [].
>> >
>> > Signed-off-by: YAMAMOTO Takashi <yamamoto at ovn.org>
>>
>> Hmm, I hadn't noticed use of "sort -d" here before.  Do you think it is
>> worth using at all?
>>
>
> "sort -d" or some equivalent would be necessary here, because
> uuid can start with either numbers and alphabets, and "[]" is after
> numbers and before alphabets.
>
>
>> Acked-by: Ben Pfaff <blp at ovn.org>
>>
>
pushed to master.  thank you.



More information about the dev mailing list