[ovs-dev] [PATCH] stp: Initialize mutex whenever we register unixctl command.

[Jarno Rajahalme]

I checked to see if lib/rstp.c has the same issue, but it has a static initializer for its mutex, so I guess not.

  Jarno

> On May 20, 2016, at 10:06 AM, Ben Pfaff <blp at ovn.org> wrote:
> 
> On Fri, May 20, 2016 at 05:30:25PM +0200, Quentin Monnet wrote:
>> Hi Ben,
>> 
>> 2016-05-20 (07:49 -0700) ~ Ben Pfaff
>>> The stp/tcn command, which locks the mutex, was being registered without
>>> initializing the mutex, so calling stp/tcn before STP was enabled on the
>>> switch caused a crash.  This commit fixes the bug by initializing the mutex
>>> at the same time we register the stp/tcn command.
>>> 
>>> Reported-by: Ding Zhi <zhi.ding at 6wind.com>
>>> Reported-at: http://openvswitch.org/pipermail/dev/2016-May/071381.html
>>> Signed-off-by: Ben Pfaff <blp at ovn.org>
>>> ---
>>> AUTHORS   |  1 +
>>> lib/stp.c | 27 +++++++++++++++------------
>>> 2 files changed, 16 insertions(+), 12 deletions(-)
>>> 
>>> diff --git a/AUTHORS b/AUTHORS
>>> index 39ac60b..e39c2f0 100644
>>> --- a/AUTHORS
>>> +++ b/AUTHORS
>>> @@ -300,6 +300,7 @@ David Palma             palma at onesource.pt
>>> Derek Cormier           derek.cormier at lab.ntt.co.jp
>>> Dhaval Badiani          dbadiani at vmware.com
>>> DK Moon                 dkmoon at nicira.com
>>> +Dong Zhi                zhi.ding at 6wind.com
>> 
>> Please note that there is a typo here in the name of the author (“Ding”).
> 
> Oops.  Fixed.
> 
>>> Edwin Chiu              echiu at vmware.com <mailto:echiu at vmware.com>
>>> Eivind Bulie Haanaes
>>> Enas Ahmad              enas.ahmad at kaust.edu.sa <mailto:enas.ahmad at kaust.edu.sa>
>>> diff --git a/lib/stp.c b/lib/stp.c
>>> index 0f92ed1..ecef012 100644
>>> […]
>> 
>> This patch does address the issue of my previous email (
>> http://openvswitch.org/pipermail/dev/2016-May/071381.html <http://openvswitch.org/pipermail/dev/2016-May/071381.html> ). Thanks!
>> 
>> Test-by: Quentin Monnet <quentin.monnet at 6wind.com <mailto:quentin.monnet at 6wind.com>>
> 
> Thanks, I applied this to master, branch-2.5, branch-2.4, and
> branch-2.3.
> _______________________________________________
> dev mailing list
> dev at openvswitch.org <mailto:dev at openvswitch.org>
> http://openvswitch.org/mailman/listinfo/dev <http://openvswitch.org/mailman/listinfo/dev>