[ovs-dev] [PATCH 2/2] [PATCH v4] datapath-windows: Add Geneve support

[Jesse Gross]

On Fri, May 20, 2016 at 1:57 PM, Yin Lin <linyi at vmware.com> wrote:
> diff --git a/datapath-windows/ovsext/Geneve.c b/datapath-windows/ovsext/Geneve.c
> new file mode 100644
> index 0000000..8184739
> --- /dev/null
> +++ b/datapath-windows/ovsext/Geneve.c
> +NDIS_STATUS OvsDecapGeneve(POVS_SWITCH_CONTEXT switchContext,
> +                           PNET_BUFFER_LIST curNbl,
> +                           OvsIPv4TunnelKey *tunKey,
> +                           PNET_BUFFER_LIST *newNbl)
[...]
> +    /* Calculate and verify UDP checksum if NIC didn't do it. */
> +    if (udpHdr->check != 0) {
> +        status = OvsCalculateUDPChecksum(curNbl, curNb, ipHdr, udpHdr, packetLength);
> +        if (status != NDIS_STATUS_SUCCESS) {
> +            goto dropNbl;
> +        }
> +    }

Sorry, I should have noticed this earlier but it looks like we're not
setting OVS_TNL_F_CSUM here to let userspace know that the packet was
protected by a checksum. You can refer to Alin's patch for how he did
it with VXLAN.

As a further minor procedural tip, typically all patches in a series
would have the same version number (in this case v4, instead of v2 on
the first patch and v4 on the second). This makes it easier to be sure
that you're looking at the most recent version.