[ovs-dev] Trying to decide of the following clean up code in a test case is a bug or not

Ben Pfaff blp at ovn.org
Mon May 23 17:34:27 UTC 2016


On Fri, May 20, 2016 at 05:12:12PM -0500, Ryan Moats wrote:
> I'm looking at the cleanup portion of the "ovn -- send gratuitous arp
> on localnet" test case at lines 2591-2593 in tests/ovn.at:
> 
> # Delete the localnet ports.
> AT_CHECK([ovs-vsctl del-port localvif1])
> AT_CHECK([ovn-nbctl lport-del ln_port])
> 
> What appears to be happening is that the port is removed from the
> openvswitch, but the corresponding Port_Binding row isn't automatically
> removed.  This doesn't cause a problem when rebuilding everything in
> each iteration, but it is causing me some headaches when trying to
> persist.

One would expect that, following the ovs-vsctl, ovn-controller would set
the chassis column in the appropriate Port_Binding row to the empty set.
Only "ovn-nbctl lport-del" should actually remove the row.

> Adding in an explicit "ovn-nbctl lport-del localvif1" make the test
> pass, but that strikes me as "not good enough", so I'm wondering
> how I could catch the fact that the port is no longer on the
> vswitch in patch_run...

Does the above help?



More information about the dev mailing list