[ovs-dev] [PATCH v2 0/2] vhost-user: Add the ability to control ownership/permissions

[Aaron Conole]

Christian Ehrhardt <christian.ehrhardt at canonical.com> writes:

> Hi Aaron,
> not on this revision, but I tested and liked your series quite a lot when
> it was still younger :-).
> While I still think a long term solution should be in DPDK itself - as you
> have seen the discussion there tended to add an extra API.
> That can take a while plus the adoption in consuming projects - so I
> totally like your fix for the situation as it is right now.
>
> That said (is one a superset of the other?):
> Acked-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>
> Tested-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>

Thanks. It is slightly different (only because the user and group
parsing code is quite a bit more enhanced), but the "user experience"
side (ie: how to set the configurations) hasn't changed. And I've
enhanced the ch(mod/own) code to support some "fancy" features, along
with adding tests. So, you might want to apply and test it before giving
your tags.

That said, I'm glad you're confident enough in my work. That makes one
of us :-)

> Kind regards,
> Christian
>
> Christian Ehrhardt
> Software Engineer, Ubuntu Server
> Canonical Ltd
>
> On Fri, May 20, 2016 at 10:32 PM, Aaron Conole <aconole at redhat.com> wrote:
>
>> Currently, when using Open vSwitch with DPDK and qemu guests, the
>> recommended
>> method for joining the guests is via the dpdkvhostuser interface. This
>> interface uses Unix Domain sockets to communicate. When these sockets are
>> created, they inherit the permissions and ownership from the vswitchd
>> process.
>> This can lead to an undesirable state where the QEMU process cannot use the
>> socket file until manual intervention is performed (via `chown` and/or
>> `chmod`
>> calls).
>>
>> This patchset gives the ability to set the permissions and ownership of all
>> dpdkvhostuser sockets from the database, avoiding the manual intervention
>> required to connect QEMU and OVS via DPDK.
>>
>> The first patch adds chmod and chown calls to lib, with unit tests. The
>> second patch hooks those calls into the netdev_dpdk_vhost_user_construct
>> function, after the socket is created.
>>
>> Aaron Conole (2):
>>   chutil: introduce a new change-utils lib
>>   netdev-dpdk: Support user-defined socket attribs
>>
>>  INSTALL.DPDK.md      |   7 ++
>>  NEWS                 |   2 +
>>  lib/automake.mk      |   2 +
>>  lib/chutil-unix.c    | 332
>> +++++++++++++++++++++++++++++++++++++++++++++++++++
>>  lib/chutil.h         |  32 +++++
>>  lib/daemon-unix.c    | 149 +----------------------
>>  lib/netdev-dpdk.c    |  26 +++-
>>  tests/automake.mk    |   2 +
>>  tests/library.at     |   5 +
>>  tests/test-chutil.c  | 237 ++++++++++++++++++++++++++++++++++++
>>  vswitchd/vswitch.xml |  23 ++++
>>  11 files changed, 670 insertions(+), 147 deletions(-)
>>  create mode 100644 lib/chutil-unix.c
>>  create mode 100644 lib/chutil.h
>>  create mode 100644 tests/test-chutil.c
>>
>> --
>> 2.5.5
>>
>>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev