[ovs-dev] [PATCH v7 1/2] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

Numan Siddique nusiddiq at redhat.com
Tue May 24 06:47:54 UTC 2016


On Tue, May 24, 2016 at 12:42 AM, Ramu Ramamurthy <ramu.ramamurthy at gmail.com
> wrote:

> Tested-by: Ramu Ramamurthy <ramu.ramamurthy at us.ibm.com>
>
> I tested this patchset to work end-to-end with openstack (with the
> corresponding WIP openstack patch).
>
> > +    /* Check that the DHCP Message Type (opt 53) is present or not with
> > +     * valid values - DHCP_MSG_DISCOVER or DHCP_MSG_REQUEST as the first
> > +     * DHCP option.
> > +     */
> > +    if (!(in_dhcp_opt[0] == DHCP_OPT_MSG_TYPE && in_dhcp_opt[1] == 1 &&
> (
> > +            in_dhcp_opt[2] == DHCP_MSG_DISCOVER ||
> > +            in_dhcp_opt[2] == DHCP_MSG_REQUEST))) {
> > +        /* Invalid dhcp packet. Resume the packet without further
> > +         * processing. */
> > +        goto exit;
> > +    }
> > +
>
> Would it make sense to log messages are not handling (nak, decline,
> release, inform)
>  to help debug (rare) scenarios when VMs dont get dhcp IPs as expected.
>


​Thanks for testing Ramu. I think it makes sense. I will spin another
patchset with
the logs.

Thanks
Numan
​



More information about the dev mailing list