[ovs-dev] [ovs-dev, v2] dpif-netdev: Destroy pmd threads only if pmd-cpu-mask changed.

Ryan Moats rmoats at us.ibm.com
Tue May 24 18:21:01 UTC 2016


Ilya Maximets <i.maximets at samsung.com> wrote on 05/23/2016 02:57:07 AM:

> From: Ilya Maximets <i.maximets at samsung.com>
> To: Ryan Moats/Omaha/IBM at IBMUS
> Cc: Flavio Leitner <fbl at sysclose.org>, Daniele Di Proietto
> <diproiettod at vmware.com>, Dyasly Sergey <s.dyasly at samsung.com>, Joe
> Stringer <joestringer at nicira.com>, "dev at openvswitch.org"
<dev at openvswitch.org>
> Date: 05/23/2016 02:57 AM
> Subject: Re: [ovs-dev] [ovs-dev, v2] dpif-netdev: Destroy pmd
> threads only if pmd-cpu-mask changed.
>
> CC: mail-list.
> Sorry.
>
> On 23.05.2016 10:49, Ilya Maximets wrote:
> > Hi, Ryan.
> > This patch currently conflicts with patch-set 'Reconfigure netdev at
> > runtime' from Daniele Di Proietto
> > ( http://openvswitch.org/pipermail/dev/2016-April/070064.html ),
> > which, I think, is more important to apply now.
> > We will think about future of this change later.
> >
> > Best regards, Ilya Maximets.
> >
> > P.S. It would be nice to add involved people to CC-list while sending
> > emails. Replying to original message also would be a good idea. Thanks.
> >
> >
> > On 09.05.2016 20:31, Ryan Moats wrote:
> >> "dev" <dev-bounces at openvswitch.org> wrote on 02/24/2016 12:47:34 PM
> >>
> >>> From: Ilya Maximets <i.maximets at samsung.com>
> >>> X-Patchwork-Id: 587370
> >>> Message-Id: <1456318054-4789-1-git-send-email-i.maximets at
samsung.com>
> >>> To: dev at openvswitch.org, Daniele Di Proietto <diproiettod at
> vmware.com>
> >>> Cc: Ilya Maximets <i.maximets at samsung.com>, Flavio Leitner
> >> <fbl at sysclose.org>,
> >>>  Joe Stringer <joestringer at nicira.com>, Dyasly Sergey
> >> <s.dyasly at samsung.com>
> >>> Date: Wed, 24 Feb 2016 15:47:34 +0300
> >>>
> >>> Since 5f2ccb1c0d3b ("dpif: Allow adding ukeys for same flow by
> >>> different pmds.") there is the possibility to reassign queues among
> >>> pmd threads without restarting them and deleting the megaflow cache.
> >>>
> >>> So, reconfiguration can be performed without destroying of PMD
threads
> >>> if pmd-cpu-mask not changed.
> >>>
> >>> Reassignment of all rx queues done to achieve fair distribution.
> >>>
> >>> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
> >>> Acked-by: Flavio Leitner <fbl at sysclose.org>
> >>> ---
> >>
> >> While looking back at the tail of the patch queue, I came across this
> >> and I'm not sure what it's status is - the patch doesn't merge cleanly
> >> now (part 2 fails) and so if it is still valid, can we get a rebase?
> >>
> >> Thanks,
> >> Ryan
> >>
>

Thanks and understood - unfortunately, I didn't have the original email
handy and didn't want to forget while I dug it out.

Ryan



More information about the dev mailing list