[ovs-dev] [PATCH 1/2] datapath-windows: don't map output buffer in OVS_IOCTL_WRITE

[Alin Serdean]

Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>


> -----Mesaj original-----
> De la: dev [mailto:dev-bounces at openvswitch.org] În numele Nithin Raju
> Trimis: Friday, May 20, 2016 1:32 AM
> Către: dev at openvswitch.org
> Subiect: [ovs-dev] [PATCH 1/2] datapath-windows: don't map output buffer
> in OVS_IOCTL_WRITE
> 
> The contract of OVS_IOCTL_WRITE is that write operations will not need the
> output buffer. Only the input buffer will be used in the IRP. So, better to not
> map the output buffer at all.
> 
> Signed-off-by: Nithin Raju <nithin at vmware.com>
> ---
>  datapath-windows/ovsext/Datapath.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-
> windows/ovsext/Datapath.c
> index 1f89964..e33027c 100644
> --- a/datapath-windows/ovsext/Datapath.c
> +++ b/datapath-windows/ovsext/Datapath.c
> @@ -869,19 +869,6 @@ OvsDeviceControl(PDEVICE_OBJECT deviceObject,
>              goto done;
>          }
> 
> -        /*
> -         * Output buffer not mandatory but map it in case we have something
> -         * to return to requester.
> -        */
> -        if (outputBufferLen != 0) {
> -            status = MapIrpOutputBuffer(irp, outputBufferLen,
> -                sizeof *ovsMsg, &outputBuffer);
> -            if (status != STATUS_SUCCESS) {
> -                goto done;
> -            }
> -            ASSERT(outputBuffer);
> -        }
> -
>          ovsMsg = inputBuffer;
>          ovsMsgLength = inputBufferLen;
>          devOp = OVS_WRITE_DEV_OP;
> --
> 2.7.1.windows.1
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev