[ovs-dev] [PATCH 1/6] INSTALL.md: Document system-traffic tests.

[Joe Stringer]

Thanks for the review,

On 23 May 2016 at 12:49, Andy Zhou <azhou at ovn.org> wrote:
>> @@ -101,6 +101,14 @@ To run the unit tests, you also need:
>>    - Perl.  Version 5.10.1 is known to work.  Earlier versions should
>>      also work.
>>
>> +The "system" tests for userspace and Linux datapaths also rely upon:
>
> Should we just stick with "Datapath testing"

Sure, I'll update this.

>> -Vagrant
>> --------
>> +Datapath traffic testing
>
> How about drop "traffic" from the title. More datapath features can be
> tested using
> this framework without sending any traffic through, right?

True, I'll drop it.

>> +### Native
>> +
>> +The datapath testsuite as invoked by Vagrant above may also be run
>> +manually on a Linux system with root privileges. If some tests are
>> +being skipped, consider updating your iproute2 package and Linux kernel
>> +version.
>
> This is not clear to me.

Which part? The second sentence is a bit of a tangent and could be dropped.


>>
>> These tests may take several minutes to complete, and cannot be
>> +run in parallel.
>>
>> +
>> +To invoke the system testsuite with the userspace datapath:
>> +
>> +        make check-system-userspace
>> +
>> +Make targets are also provided for testing the Linux kernel module.
>> +Note that these tests operate by inserting modules into the running
>> +Linux kernel, so if the tests are able to trigger a bug in the OVS
>> +kernel module or in the upstream kernel then the kernel may panic.
>> +
>> +To run the testsuite against the kernel module which is currently
>> +installed on your system:
>> +
>> +        make check-kernel
>> +
>> +To install the kernel module from the current build directory and
>> +run the testsuite against that kernel module:
>> +
>> +        make check-kmod
>> +
>> +The testsuite logs will be placed in tests/system-userspace-traffic.log
>> +for the userspace target, or tests/system-kmod-traffic.log for the
>> +kernel targets.
>
>
> May be it will be clearer to separately discuss kernel datapath  and user
> space
> datapath?

Sure, I can split this out.

>> +
>>  Continuous Integration with Travis-CI
>>  -------------------------------------
>>
>> --
>> 2.8.2
>>
>