[ovs-dev] [PATCH] ofproto-dpif: Log warning when ct action or its variants are not supported.

[Joe Stringer]

On 31 October 2016 at 14:33, Ben Pfaff <blp at ovn.org> wrote:
> On Mon, Oct 31, 2016 at 02:16:05PM -0700, Joe Stringer wrote:
>> On 31 October 2016 at 13:23, Ben Pfaff <blp at ovn.org> wrote:
>> > Some datapaths do not support the ct action, and others support only a
>> > subset of its features.  Until now, it has been difficult to tell why a
>> > particular action is being rejected.  This commit should make it clearer.
>> >
>> > Reported-by: Kevin Lin <kevinlin at berkeley.edu>
>> > Reported-at: http://openvswitch.org/pipermail/discuss/2016-October/023060.html
>> > Signed-off-by: Ben Pfaff <blp at ovn.org>
>>
>> Thanks, no doubt this will save a bunch of people a bunch of
>> confusion. It still doesn't directly state that "Your kernel module
>> may be out of date", but it's more clear than just OpenFlow hexdumps
>> telling you "OFPBAC". Maybe it should either say this, or this should
>> be mentioned in the FAQ.
>>
>> Acked-by: Joe Stringer <joe at ovn.org>
>
> You're right, this can be better.
>
> How about like this?
>
> --8<--------------------------cut here-------------------------->8--
>
> From: Ben Pfaff <blp at ovn.org>
> Date: Mon, 31 Oct 2016 14:33:13 -0700
> Subject: [PATCH] ofproto-dpif: Log warning when ct action or its variants are
>  not supported.
>
> Some datapaths do not support the ct action, and others support only a
> subset of its features.  Until now, it has been difficult to tell why a
> particular action is being rejected.  This commit should make it clearer.
>
> Reported-by: Kevin Lin <kevinlin at berkeley.edu>
> Reported-at: http://openvswitch.org/pipermail/discuss/2016-October/023060.html
> Signed-off-by: Ben Pfaff <blp at ovn.org>

Looks good, thanks!