[ovs-dev] [PATCH] ovn: fix ovn-northd leak in build_acls

Flavio Fernandes flavio at flaviof.com
Tue Nov 1 21:19:59 UTC 2016


Avoid leak due to missing ds_destroy in build_acl for non-stateful
drop action.

Found via inspection.  I do not know that this fixes a common leak.

Signed-off-by: Flavio Fernandes <flavio at flaviof.com>
---
 ovn/northd/ovn-northd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index ad0739c..91affe4 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -2571,6 +2571,7 @@ build_acls(struct ovn_datapath *od, struct hmap *lflows)
                 ovn_lflow_add(lflows, od, stage,
                               acl->priority + OVN_ACL_PRI_OFFSET,
                               acl->match, "drop;");
+                ds_destroy(&match);
             }
         }
     }
-- 
2.7.4




More information about the dev mailing list