[ovs-dev] [PATCH 1/5 v2] datapath-windows: clean code in vxlan

Sairam Venugopal vsairam at vmware.com
Thu Nov 3 23:28:12 UTC 2016


Acked-by: Sairam Venugopal <vsairam at vmware.com>


On 10/27/16, 11:53 AM, "Alin Serdean" <aserdean at cloudbasesolutions.com>
wrote:

>The purpose of this patch is to make the code more readable and
>fix a static analyzer warning.
>
>Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
>---
> datapath-windows/ovsext/Vxlan.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/datapath-windows/ovsext/Vxlan.c
>b/datapath-windows/ovsext/Vxlan.c
>index ddd8d8e..db45248 100644
>--- a/datapath-windows/ovsext/Vxlan.c
>+++ b/datapath-windows/ovsext/Vxlan.c
>@@ -260,10 +260,10 @@ OvsDoEncapVxlan(POVS_VPORT_ENTRY vport,
> 
>         /* L2 header */
>         ethHdr = (EthHdr *)bufferStart;
>-        ASSERT(((PCHAR)&fwdInfo->dstMacAddr + sizeof
>fwdInfo->dstMacAddr) ==
>-               (PCHAR)&fwdInfo->srcMacAddr);
>         NdisMoveMemory(ethHdr->Destination, fwdInfo->dstMacAddr,
>-                       sizeof ethHdr->Destination + sizeof
>ethHdr->Source);
>+                       sizeof ethHdr->Destination);
>+        NdisMoveMemory(ethHdr->Source, fwdInfo->srcMacAddr,
>+                       sizeof ethHdr->Source);
>         ethHdr->Type = htons(ETH_TYPE_IPV4);
> 
>         /* IP header */
>-- 
>2.9.2.windows.1
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma
>n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc
>ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=ckorSSUiXYfoJrNwZ5y80-Tq_qOqiC
>ANsHBKrdp-t1Q&s=0m71pUvuTgm9YNoDPqlwHo5jcK_DEonvsikJCJyP9TQ&e= 




More information about the dev mailing list