[ovs-dev] [PATCH 1/2] ovsdb windows: Allow online compacting

Alin Serdean aserdean at cloudbasesolutions.com
Wed Nov 9 12:58:16 UTC 2016


>
> 
> This had some bugs.
> 
> The worst one was that it deleted all the data from the database.  This wasn't
> evident from the test because it only deleted it from the on-disk
> representation and the test didn't actually restart the server.  I've fixed both
> problems.
[Alin Serdean] Sorry I missed it.
> 
> The lesser one was that it had more duplicate code than needed and extra
> #ifdefs made it harder than necessary to test the "Windows" approach on
> Unix-like systems.  I've fixed that too.
> 
> So, here's my proposed version of the patch.  What do you think?
[Alin Serdean] Looks much more elegant. Thanks, a lot!
I tested using the incremental.
Tested-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>



More information about the dev mailing list