[ovs-dev] [PATCH 2/3] util: Use vlog for ovs_abort().

Ben Pfaff blp at ovn.org
Thu Nov 10 21:42:45 UTC 2016


On Thu, Nov 10, 2016 at 01:28:22PM -0800, Joe Stringer wrote:
> Previously, if vswitchd aborted then the log message would only be
> printed to stderr, which may be hidden depending on how OVS is run.
> Use vlog as well so that the error shows up in the logs.
> 
> Signed-off-by: Joe Stringer <joe at ovn.org>

We should only use ovs_abort() in cases where it's potentially risky to
call into vlog.  Otherwise we should use vlog_abort().

It's easy to choose wrong.  Do you see some places where we got it wrong?



More information about the dev mailing list