[ovs-dev] [PATCH 2/3] util: Use vlog for ovs_abort().

[Joe Stringer]

On 10 November 2016 at 13:42, Ben Pfaff <blp at ovn.org> wrote:
> On Thu, Nov 10, 2016 at 01:28:22PM -0800, Joe Stringer wrote:
>> Previously, if vswitchd aborted then the log message would only be
>> printed to stderr, which may be hidden depending on how OVS is run.
>> Use vlog as well so that the error shows up in the logs.
>>
>> Signed-off-by: Joe Stringer <joe at ovn.org>
>
> We should only use ovs_abort() in cases where it's potentially risky to
> call into vlog.  Otherwise we should use vlog_abort().
>
> It's easy to choose wrong.  Do you see some places where we got it wrong?

I was debugging some locking stuff with some WIP code and found that
when pthread returns errors, the logs would provide no details on the
termination. I suppose that in such cases we treat it as being risky
to use vlog (because vlog also does some locking). In that case,
atleast I understand the reasoning, could drop this patch.