[ovs-dev] [PATCH ovs V1 0/9] Introducing HW offload support for openvswitch

Paul Blakey paulb at mellanox.com
Mon Nov 14 08:31:31 UTC 2016



On 07/11/2016 02:02, Joe Stringer wrote:
> On 3 November 2016 at 06:19, Simon Horman <simon.horman at netronome.com> wrote:
>> Hi Paul,
>>
>> thanks for this very interesting work. I hope we can see offload support
>> present in OvS in the not too distant future.
>>
>> Looking over the patches I have a few high-level comments:
>>
>> * Please run the code through ./utilities/checkpatch.py

   ok.

>> * Please consider referring to flower or tc-flower instead of tc.
>>    I think its somewhat misleading to claim this is TC in general in
>>    its current form. (I think someone else raised this offline but you were
>>    not present)
> Yes, for instance lib/tc.[ch] is almost exclusively flower stuff. I
> think it should be something like tc-flower.[ch].

Makes sense, we'll do that.

>
>> * Am I right in thinking that the current implementation only allows
>>    offloading flows that output to one port? If so I'd like to hear your
>>    thoughts on how that restriction might be lifted.
> I would also suggest linking travis-ci to your github account and
> pushing a branch to see that travis validates your build with
> different compilers, platforms and so on.

ok, we'll do that too.



More information about the dev mailing list