[ovs-dev] [PATCH] sflow: Expose ethernet and vlan stats via sFlow

Robert Wojciechowicz robertx.wojciechowicz at intel.com
Thu Nov 17 08:44:21 UTC 2016


On Wed, Nov 16, 2016 at 08:40:42AM -0700, Neil McKee wrote:
> If there is only one VLAN then the numbers are redundant - already exported
> in the struct if_counters.
> 
> The vlan_counters structure was never intended to be exported by an
> interface.  It was designed for the (rarely used) vlan datasource -- that's
> why the counters in it are not directional.
> 
> So I don't think you would be losing anything by leaving it out.

I thought that those counters for specific vlan_id might be interesting,
but ok if it is not useful I will leave it out.
So I'm going to correct this patch by just removing those vlan counters.
Thank you very much for your comments.

Br,
Robert



More information about the dev mailing list