[ovs-dev] [PATCH] sflow: Expose ethernet and vlan stats via sFlow

Neil McKee neil.mckee at inmon.com
Thu Nov 17 18:21:23 UTC 2016


I'm wondering if the ethernet stats block is going to mean anything for
virtual interfaces.  What if we only export it for physical interfaces?
That might reduce the overhead significantly.   (Maybe your patch already
does this - I haven't read it carefully enough to be sure).

Neil


------
Neil McKee
InMon Corp.
http://www.inmon.com

On Thu, Nov 17, 2016 at 12:44 AM, Robert Wojciechowicz <
robertx.wojciechowicz at intel.com> wrote:

> On Wed, Nov 16, 2016 at 08:40:42AM -0700, Neil McKee wrote:
> > If there is only one VLAN then the numbers are redundant - already
> exported
> > in the struct if_counters.
> >
> > The vlan_counters structure was never intended to be exported by an
> > interface.  It was designed for the (rarely used) vlan datasource --
> that's
> > why the counters in it are not directional.
> >
> > So I don't think you would be losing anything by leaving it out.
>
> I thought that those counters for specific vlan_id might be interesting,
> but ok if it is not useful I will leave it out.
> So I'm going to correct this patch by just removing those vlan counters.
> Thank you very much for your comments.
>
> Br,
> Robert
>
>


More information about the dev mailing list