[ovs-dev] [PATCH] sflow: Expose ethernet and vlan stats via sFlow

Robert Wojciechowicz robertx.wojciechowicz at intel.com
Fri Nov 18 12:14:50 UTC 2016


On Thu, Nov 17, 2016 at 10:21:23AM -0800, Neil McKee wrote:
> I'm wondering if the ethernet stats block is going to mean anything for
> virtual interfaces.  What if we only export it for physical interfaces?
> That might reduce the overhead significantly.   (Maybe your patch already
> does this - I haven't read it carefully enough to be sure).

Basically I wanted to make the sflow data consistent with netdev
statistics ("ovs-ofctl dump-ports"). In netdev statistics 
in case of unknown value there is question mark in output 
or the value is left out but there is no logic regarding 
the interface type.
In sflow case there will be sent UINT_MAX (unkown counter). 
The only risk is that the whole ethernet structure will contain 
unkown counters for some interface. So maybe I can add
checking if at least one counter contains known value
and only then send this structure.
What do you think?

Br,
Robert



More information about the dev mailing list